Commit 2f4a3d8b authored by Rikard Falkeborn's avatar Rikard Falkeborn Committed by Vinod Koul
Browse files

phy: cadence: salvo: Constify cdns_nxp_sequence_pair 



cdns_nxp_sequence_pair[] are never modified and can be made const to allow
the compiler to put them in read-only memory.

Signed-off-by: default avatarRikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: default avatarPeter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/20200912204639.501669-3-rikard.falkeborn@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3cfb0e8e

drivers/phy/cadence/phy-cadence-salvo.c

+3 −3
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ struct cdns_reg_pairs { 


struct cdns_salvo_data {

	u8 reg_offset_shift;

	struct cdns_reg_pairs *init_sequence_val;

	const struct cdns_reg_pairs *init_sequence_val;

	u8 init_sequence_length;

};
@@ -126,7 +126,7 @@ static void cdns_salvo_write(struct cdns_salvo_phy *salvo_phy, 
 * Below bringup sequence pair are from Cadence PHY's User Guide

 * and NXP platform tuning results.

 */

static struct cdns_reg_pairs cdns_nxp_sequence_pair[] = {

static const struct cdns_reg_pairs cdns_nxp_sequence_pair[] = {

	{0x0830, PHY_PMA_CMN_CTRL1},

	{0x0010, TB_ADDR_CMN_DIAG_HSCLK_SEL},

	{0x00f0, TB_ADDR_CMN_PLL0_VCOCAL_INIT_TMR},
@@ -217,7 +217,7 @@ static int cdns_salvo_phy_init(struct phy *phy) 
		return ret;



	for (i = 0; i < data->init_sequence_length; i++) {

		struct cdns_reg_pairs *reg_pair = data->init_sequence_val + i;

		const struct cdns_reg_pairs *reg_pair = data->init_sequence_val + i;



		cdns_salvo_write(salvo_phy, reg_pair->off, reg_pair->val);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE