Commit 2f4701d8 authored by James.Smart@Emulex.Com's avatar James.Smart@Emulex.Com Committed by James Bottomley
Browse files

[SCSI] add int_to_scsilun() function 

One of the issues we had was reverting the midlayers lun value
into the 8byte lun value that we wanted to send to the device.
Historically, there's been some combination of byte swapping,
setting high/low, etc. There's also been no common thread between
how our driver did it and others.  I also got very confused as
to why byteswap routines were being used.

Anyway, this patch is a LLDD-callable function that reverts the
midlayer's lun value, stored in an int, to the 8-byte quantity
(note: this is not the real 8byte quantity, just the same amount
that scsilun_to_int() was able to convert and store originally).

This also solves the dilemma of the thread:
http://marc.theaimsgroup.com/?l=linux-kernel&m=112116767118981&w=2



A patch for the lpfc driver to use this function will be along
in a few days (batched with other patches).

Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 77d74143

drivers/scsi/scsi_scan.c

+32 −0
Original line number Diff line number Diff line
@@ -999,6 +999,38 @@ static int scsilun_to_int(struct scsi_lun *scsilun) 
	return lun;

}



/**

 * int_to_scsilun: reverts an int into a scsi_lun

 * @int:        integer to be reverted

 * @scsilun:	struct scsi_lun to be set.

 *

 * Description:

 *     Reverts the functionality of the scsilun_to_int, which packed

 *     an 8-byte lun value into an int. This routine unpacks the int

 *     back into the lun value.

 *     Note: the scsilun_to_int() routine does not truly handle all

 *     8bytes of the lun value. This functions restores only as much

 *     as was set by the routine.

 *

 * Notes:

 *     Given an integer : 0x0b030a04,  this function returns a

 *     scsi_lun of : struct scsi_lun of: 0a 04 0b 03 00 00 00 00

 *

 **/

void int_to_scsilun(unsigned int lun, struct scsi_lun *scsilun)

{

	int i;



	memset(scsilun->scsi_lun, 0, sizeof(scsilun->scsi_lun));



	for (i = 0; i < sizeof(lun); i += 2) {

		scsilun->scsi_lun[i] = (lun >> 8) & 0xFF;

		scsilun->scsi_lun[i+1] = lun & 0xFF;

		lun = lun >> 16;

	}

}

EXPORT_SYMBOL(int_to_scsilun);



/**

 * scsi_report_lun_scan - Scan using SCSI REPORT LUN results

 * @sdevscan:	scan the host, channel, and id of this Scsi_Device

include/scsi/scsi_device.h

+1 −0
Original line number Diff line number Diff line
@@ -243,6 +243,7 @@ extern void scsi_target_reap(struct scsi_target *); 
extern void scsi_target_block(struct device *);

extern void scsi_target_unblock(struct device *);

extern void scsi_remove_target(struct device *);

extern void int_to_scsilun(unsigned int, struct scsi_lun *);

extern const char *scsi_device_state_name(enum scsi_device_state);

extern int scsi_is_sdev_device(const struct device *);

extern int scsi_is_target_device(const struct device *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE