Commit 2f33a706 authored May 27, 2020 by Hugh Dickins Committed by Linus Torvalds May 28, 2020

mm,thp: stop leaking unreleased file pages



When collapse_file() calls try_to_release_page(), it has already isolated
the page: so if releasing buffers happens to fail (as it sometimes does),
remember to putback_lru_page(): otherwise that page is left unreclaimable
and unfreeable, and the file extent uncollapsible.

Fixes: 99cb0dbd ("mm,thp: add read-only THP support for (non-shmem) FS")
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Song Liu <songliubraving@fb.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: <stable@vger.kernel.org>	[5.4+]
Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2005231837500.1766@eggly.anvils


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent af4798a5

mm/khugepaged.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1692,6 +1692,7 @@ static void collapse_file(struct mm_struct *mm,
		if (page_has_private(page) &&
		!try_to_release_page(page, GFP_KERNEL)) {
		result = SCAN_PAGE_HAS_PRIVATE;
		putback_lru_page(page);
		goto out_unlock;
		}

Admin message