Commit 2f10d823 authored Jan 25, 2019 by Gustavo A. R. Silva Committed by Alex Deucher Jan 29, 2019

drm/amd/powerplay: Fix missing break in switch



Add missing break statement in order to prevent the code from falling
through to the default case.

The resoning for this is that pclk_vol_table is an automatic variable.
So, it makes no sense to update it just before falling through to the
default case and return -EINVAL.

This bug was found thanks to the ongoing efforts to enabling
-Wimplicit-fallthrough.

Fixes: cd70f3d6 ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent afeff4c1

drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr,
		break;
		case amd_pp_dpp_clock:
		pclk_vol_table = pinfo->vdd_dep_on_dppclk;
		break;
		default:
		return -EINVAL;
		}

Admin message