Commit 2f0b3d60 authored Dec 21, 2008 by Avi Kivity

KVM: MMU: Segregate mmu pages created with different cr4.pge settings



Don't allow a vcpu with cr4.pge cleared to use a shadow page created with
cr4.pge set; this might cause a cr3 switch not to sync ptes that have the
global bit set (the global bit has no effect if !cr4.pge).

This can only occur on smp with different cr4.pge settings for different
vcpus (since a cr4 change will resync the shadow ptes), but there's no
cost to being correct here.

Signed-off-by: Avi Kivity <avi@redhat.com>

parent a770f6f2

arch/x86/include/asm/kvm_host.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -183,6 +183,7 @@ union kvm_mmu_page_role {
		unsigned metaphysical:1;
		unsigned access:3;
		unsigned invalid:1;
		unsigned cr4_pge:1;
		};
		};

arch/x86/kvm/x86.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -364,6 +364,7 @@ void kvm_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
		}
		kvm_x86_ops->set_cr4(vcpu, cr4);
		vcpu->arch.cr4 = cr4;
		vcpu->arch.mmu.base_role.cr4_pge = !!(cr4 & X86_CR4_PGE);
		kvm_mmu_sync_global(vcpu);
		kvm_mmu_reset_context(vcpu);
		}

Admin message