Commit 2f0a6174 authored Dec 18, 2018 by YueHaibing Committed by Steve French Dec 28, 2018

cifs: Use GFP_ATOMIC when a lock is held in cifs_mount()



A spin lock is held before kstrndup, it may sleep with holding
the spinlock, so we should use GFP_ATOMIC instead.

Fixes: e58c31d5e387 ("cifs: Add support for failover in cifs_reconnect()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>

parent 93d5cb51

fs/cifs/connect.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4585,7 +4585,8 @@ int cifs_mount(struct cifs_sb_info cifs_sb, struct smb_vol vol)
		tcon->remap = cifs_remap(cifs_sb);
		}
		cifs_sb->origin_fullpath = kstrndup(tcon->dfs_path,
		strlen(tcon->dfs_path), GFP_KERNEL);
		strlen(tcon->dfs_path),
		GFP_ATOMIC);
		if (!cifs_sb->origin_fullpath) {
		spin_unlock(&cifs_tcp_ses_lock);
		rc = -ENOMEM;

Admin message