dmaengine: bcm2835: Drop local dma_parms (2f02b23c) · Commits · 戴 / test

Since commit ("driver core: platform: Initialize dma_parms for platform devices"), struct platform_device already provides a dma_parms structure, so we can save allocating another one. Signed-off-by:

Robin Murphy <robin.murphy@arm.com> Link: https://lore.kernel.org/r/116927330a4a66aac579ad38ddbc3b538cd9524c.1599164692.git.robin.murphy@arm.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/bcm2835-dma.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -41,14 +41,12 @@
		* struct bcm2835_dmadev - BCM2835 DMA controller
		* @ddev: DMA device
		* @base: base address of register map
		* @dma_parms: DMA parameters (to convey 1 GByte max segment size to clients)
		* @zero_page: bus address of zero page (to detect transactions copying from
		* zero page and avoid accessing memory if so)
		*/
		struct bcm2835_dmadev {
		struct dma_device ddev;
		void __iomem *base;
		struct device_dma_parameters dma_parms;
		dma_addr_t zero_page;
		};

		@@ -902,7 +900,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
		if (!od)
		return -ENOMEM;

		pdev->dev.dma_parms = &od->dma_parms;
		dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Admin message