Commit 2f025ea0 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf annotate: Introduce annotation_line__max_percent() 

Out of the annotate_browser__write() routine, to be used in the --stdio2
mode.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-0he0wyy4haswqi1qb35x37do@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ecda45bd

tools/perf/ui/browsers/annotate.c

+1 −6
Original line number Diff line number Diff line
@@ -117,15 +117,10 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int 
	int width = browser->width, printed;

	int i, pcnt_width = annotation__pcnt_width(notes),

	       cycles_width = annotation__cycles_width(notes);

	double percent_max = 0.0;

	double percent_max = annotation_line__max_percent(al, notes);

	char bf[256];

	bool show_title = false;



	for (i = 0; i < notes->nr_events; i++) {

		if (al->samples[i].percent > percent_max)

			percent_max = al->samples[i].percent;

	}



	if ((row == 0) && (al->offset == -1 || percent_max == 0.0)) {

		if (notes->have_cycles) {

			if (al->ipc == 0.0 && al->cycles == 0)

tools/perf/util/annotate.c

+14 −0
Original line number Diff line number Diff line
@@ -2184,6 +2184,20 @@ bool ui__has_annotation(void) 
	return use_browser == 1 && perf_hpp_list.sym;

}





double annotation_line__max_percent(struct annotation_line *al, struct annotation *notes)

{

	double percent_max = 0.0;

	int i;



	for (i = 0; i < notes->nr_events; i++) {

		if (al->samples[i].percent > percent_max)

			percent_max = al->samples[i].percent;

	}



	return percent_max;

}



int symbol__annotate2(struct symbol *sym, struct map *map, struct perf_evsel *evsel,

		      struct annotation_options *options, struct arch **parch)

{

tools/perf/util/annotate.h

+3 −0
Original line number Diff line number Diff line
@@ -124,6 +124,9 @@ bool disasm_line__is_valid_jump(struct disasm_line *dl, struct symbol *sym); 
void disasm_line__free(struct disasm_line *dl);

struct annotation_line *

annotation_line__next(struct annotation_line *pos, struct list_head *head);



double annotation_line__max_percent(struct annotation_line *al, struct annotation *notes);



int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw);

size_t disasm__fprintf(struct list_head *head, FILE *fp);

void symbol__calc_percent(struct symbol *sym, struct perf_evsel *evsel);

CRA Git | Maintained and supported by SUSTech CRA and CCSE