Commit 2f000308 authored Mar 03, 2020 by Chris Wilson

drm/i915: Drop vma is-closed assertion on insert

The is-closed flag may be added after we have acquired the vma under the
ctx->mutex, but will not take effect until after we release the
vm->mutex. i.e. the flag may be set on the vma as attempt to bind it and
that will cause the vma to be unbound later after we unpin it.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200303093157.1153887-1-chris@chris-wilson.co.uk

parent 61231f6b

drivers/gpu/drm/i915/i915_vma.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -641,7 +641,6 @@ i915_vma_insert(struct i915_vma *vma, u64 size, u64 alignment, u64 flags)
		u64 start, end;
		int ret;

		GEM_BUG_ON(i915_vma_is_closed(vma));
		GEM_BUG_ON(i915_vma_is_bound(vma, I915_VMA_GLOBAL_BIND \| I915_VMA_LOCAL_BIND));
		GEM_BUG_ON(drm_mm_node_allocated(&vma->node));