Commit 2ef5692e authored Mar 28, 2013 by Mengdong Lin Committed by Takashi Iwai Apr 02, 2013

ALSA: hda - bug fix on return value when getting HDMI ELD info



In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
Otherwise it will be returned uninitialized as non-zero after ELD info is got
successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
by mistake, and /proc file system cannot show the proper ELD info.

Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
Cc: stable@vger.kernel.org
Acked-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent ea019fdf

sound/pci/hda/hda_eld.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
		unsigned char buf, int eld_size)
		{
		int i;
		int ret;
		int ret = 0;
		int size;

		/*

Admin message