habanalabs: block WREG_BULK packet on PDMA (2edc66e2) · Commits · 戴 / test

WREG_BULK is a special packet that has a variable length. Therefore, we can't parse it when validating CBs that go to the PCI DMA queue. In case the user needs to use it, it can put multiple WREG32 packets instead. Signed-off-by:

Oded Gabbay <oded.gabbay@gmail.com> Reviewed-by:

Omer Shpigelman <oshpigelman@habana.ai>

drivers/misc/habanalabs/gaudi/gaudi.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -3865,6 +3865,12 @@ static int gaudi_validate_cb(struct hl_device *hdev,
		rc = -EPERM;
		break;

		case PACKET_WREG_BULK:
		dev_err(hdev->dev,
		"User not allowed to use WREG_BULK\n");
		rc = -EPERM;
		break;

		case PACKET_LOAD_AND_EXE:
		rc = gaudi_validate_load_and_exe_pkt(hdev, parser,
		(struct packet_load_and_exe *) user_pkt);
		@@ -3880,7 +3886,6 @@ static int gaudi_validate_cb(struct hl_device *hdev,
		break;

		case PACKET_WREG_32:
		case PACKET_WREG_BULK:
		case PACKET_MSG_LONG:
		case PACKET_MSG_SHORT:
		case PACKET_REPEAT:

Admin message