Commit 2ed9db30 authored Jul 25, 2018 by Gustavo A. R. Silva Committed by David S. Miller Jul 26, 2018

net: sched: cls_api: fix dead code in switch



Code at line 1850 is unreachable. Fix this by removing the break
statement above it, so the code for case RTM_GETCHAIN can be
properly executed.

Addresses-Coverity-ID: 1472050 ("Structurally dead code")
Fixes: 32a4f5ec ("net: sched: introduce chain object to uapi")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2b139e6b

net/sched/cls_api.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1846,7 +1846,6 @@ replay:
	tcf_chain_put_explicitly_created(chain);		tcf_chain_put_explicitly_created(chain);
	break;		break;
	case RTM_GETCHAIN:		case RTM_GETCHAIN:
	break;
	err = tc_chain_notify(chain, skb, n->nlmsg_seq,		err = tc_chain_notify(chain, skb, n->nlmsg_seq,
	n->nlmsg_seq, n->nlmsg_type, true);		n->nlmsg_seq, n->nlmsg_type, true);
	if (err < 0)		if (err < 0)

Admin message