Commit 2ed95d2d authored May 14, 2019 by Nikolay Borisov Committed by David Sterba Jul 01, 2019

btrfs: Remove redundant assignment of tgt_device->commit_total_bytes



This is already done in btrfs_init_dev_replace_tgtdev which is the first
phase of device replace, called before doing scrub. During that time
exclusive lock is held. Additionally btrfs_fs_device::commit_total_bytes
is always set based on the size of the underlying block device which
shouldn't change once set. This makes the 2nd assignment of the variable
in the finishing phase redundant.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent f232ab04

fs/btrfs/dev-replace.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -674,7 +674,6 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
		btrfs_device_set_disk_total_bytes(tgt_device,
		src_device->disk_total_bytes);
		btrfs_device_set_bytes_used(tgt_device, src_device->bytes_used);
		tgt_device->commit_total_bytes = src_device->commit_total_bytes;
		tgt_device->commit_bytes_used = src_device->bytes_used;

		btrfs_assign_next_active_device(src_device, tgt_device);

Admin message