Commit 2ec197db authored Feb 07, 2014 by NeilBrown Committed by J. Bruce Fields Feb 13, 2014

lockd: send correct lock when granting a delayed lock.



If an NFS client attempts to get a lock (using NLM) and the lock is
not available, the server will remember the request and when the lock
becomes available it will send a GRANT request to the client to
provide the lock.

If the client already held an adjacent lock, the GRANT callback will
report the union of the existing and new locks, which can confuse the
client.

This happens because __posix_lock_file (called by vfs_lock_file)
updates the passed-in file_lock structure when adjacent or
over-lapping locks are found.

To avoid this problem we take a copy of the two fields that can
be changed (fl_start and fl_end) before the call and restore them
afterwards.
An alternate would be to allocate a 'struct file_lock', initialise it,
use locks_copy_lock() to take a copy, then locks_release_private()
after the vfs_lock_file() call.  But that is a lot more work.

Reported-by: Olaf Kirch <okir@suse.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

--
v1 had a couple of issues (large on-stack struct and didn't really work properly).
This version is much better tested.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 09bdc2d7

fs/lockd/svclock.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -779,6 +779,7 @@ nlmsvc_grant_blocked(struct nlm_block *block)
		struct nlm_file *file = block->b_file;
		struct nlm_lock *lock = &block->b_call->a_args.lock;
		int error;
		loff_t fl_start, fl_end;

		dprintk("lockd: grant blocked lock %p\n", block);

		@@ -796,9 +797,16 @@ nlmsvc_grant_blocked(struct nlm_block *block)
		}

		/* Try the lock operation again */
		/* vfs_lock_file() can mangle fl_start and fl_end, but we need
		* them unchanged for the GRANT_MSG
		*/
		lock->fl.fl_flags \|= FL_SLEEP;
		fl_start = lock->fl.fl_start;
		fl_end = lock->fl.fl_end;
		error = vfs_lock_file(file->f_file, F_SETLK, &lock->fl, NULL);
		lock->fl.fl_flags &= ~FL_SLEEP;
		lock->fl.fl_start = fl_start;
		lock->fl.fl_end = fl_end;

		switch (error) {
		case 0:

Admin message