Commit 2e91fa7f authored by Tejun Heo's avatar Tejun Heo
Browse files

cgroup: keep zombies associated with their original cgroups 



cgroup_exit() is called when a task exits and disassociates the
exiting task from its cgroups and half-attach it to the root cgroup.
This is unnecessary and undesirable.

No controller actually needs an exiting task to be disassociated with
non-root cgroups.  Both cpu and perf_event controllers update the
association to the root cgroup from their exit callbacks just to keep
consistent with the cgroup core behavior.

Also, this disassociation makes it difficult to track resources held
by zombies or determine where the zombies came from.  Currently, pids
controller is completely broken as it uncharges on exit and zombies
always escape the resource restriction.  With cgroup association being
reset on exit, fixing it is pretty painful.

There's no reason to reset cgroup membership on exit.  The zombie can
be removed from its css_set so that it doesn't show up on
"cgroup.procs" and thus can't be migrated or interfere with cgroup
removal.  It can still pin and point to the css_set so that its cgroup
membership is maintained.  This patch makes cgroup core keep zombies
associated with their cgroups at the time of exit.

* Previous patches decoupled populated_cnt tracking from css_set
  lifetime, so a dying task can be simply unlinked from its css_set
  while pinning and pointing to the css_set.  This keeps css_set
  association from task side alive while hiding it from "cgroup.procs"
  and populated_cnt tracking.  The css_set reference is dropped when
  the task_struct is freed.

* ->exit() callback no longer needs the css arguments as the
  associated css never changes once PF_EXITING is set.  Removed.

* cpu and perf_events controllers no longer need ->exit() callbacks.
  There's no reason to explicitly switch away on exit.  The final
  schedule out is enough.  The callbacks are removed.

* On traditional hierarchies, nothing changes.  "/proc/PID/cgroup"
  still reports "/" for all zombies.  On the default hierarchy,
  "/proc/PID/cgroup" keeps reporting the cgroup that the task belonged
  to at the time of exit.  If the cgroup gets removed before the task
  is reaped, " (deleted)" is appended.

v2: Build brekage due to missing dummy cgroup_free() when
    !CONFIG_CGROUP fixed.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
parent f0d9a5f1

Documentation/cgroups/unified-hierarchy.txt

+4 −0
Original line number Diff line number Diff line
@@ -374,6 +374,10 @@ supported and the interface files "release_agent" and 


- The "cgroup.clone_children" file is removed.



- /proc/PID/cgroup keeps reporting the cgroup that a zombie belonged

  to before exiting.  If the cgroup is removed before the zombie is

  reaped, " (deleted)" is appeneded to the path.





5-3. Controller File Conventions

include/linux/cgroup-defs.h

+1 −3
Original line number Diff line number Diff line
@@ -435,9 +435,7 @@ struct cgroup_subsys { 
	int (*can_fork)(struct task_struct *task, void **priv_p);

	void (*cancel_fork)(struct task_struct *task, void *priv);

	void (*fork)(struct task_struct *task, void *priv);

	void (*exit)(struct cgroup_subsys_state *css,

		     struct cgroup_subsys_state *old_css,

		     struct task_struct *task);

	void (*exit)(struct task_struct *task);

	void (*bind)(struct cgroup_subsys_state *root_css);



	int early_init;

include/linux/cgroup.h

+2 −0
Original line number Diff line number Diff line
@@ -102,6 +102,7 @@ extern void cgroup_cancel_fork(struct task_struct *p, 
extern void cgroup_post_fork(struct task_struct *p,

			     void *old_ss_priv[CGROUP_CANFORK_COUNT]);

void cgroup_exit(struct task_struct *p);

void cgroup_free(struct task_struct *p);



int cgroup_init_early(void);

int cgroup_init(void);
@@ -547,6 +548,7 @@ static inline void cgroup_cancel_fork(struct task_struct *p, 
static inline void cgroup_post_fork(struct task_struct *p,

				    void *ss_priv[CGROUP_CANFORK_COUNT]) {}

static inline void cgroup_exit(struct task_struct *p) {}

static inline void cgroup_free(struct task_struct *p) {}



static inline int cgroup_init_early(void) { return 0; }

static inline int cgroup_init(void) { return 0; }

kernel/cgroup.c

+34 −17
Original line number Diff line number Diff line
@@ -5379,13 +5379,33 @@ int proc_cgroup_show(struct seq_file *m, struct pid_namespace *ns, 
			seq_printf(m, "%sname=%s", count ? "," : "",

				   root->name);

		seq_putc(m, ':');



		cgrp = task_cgroup_from_root(tsk, root);



		/*

		 * On traditional hierarchies, all zombie tasks show up as

		 * belonging to the root cgroup.  On the default hierarchy,

		 * while a zombie doesn't show up in "cgroup.procs" and

		 * thus can't be migrated, its /proc/PID/cgroup keeps

		 * reporting the cgroup it belonged to before exiting.  If

		 * the cgroup is removed before the zombie is reaped,

		 * " (deleted)" is appended to the cgroup path.

		 */

		if (cgroup_on_dfl(cgrp) || !(tsk->flags & PF_EXITING)) {

			path = cgroup_path(cgrp, buf, PATH_MAX);

			if (!path) {

				retval = -ENAMETOOLONG;

				goto out_unlock;

			}

		} else {

			path = "/";

		}



		seq_puts(m, path);



		if (cgroup_on_dfl(cgrp) && cgroup_is_dead(cgrp))

			seq_puts(m, " (deleted)\n");

		else

			seq_putc(m, '\n');

	}
@@ -5593,7 +5613,6 @@ void cgroup_exit(struct task_struct *tsk) 
{

	struct cgroup_subsys *ss;

	struct css_set *cset;

	bool put_cset = false;

	int i;



	/*
@@ -5606,21 +5625,19 @@ void cgroup_exit(struct task_struct *tsk) 
		spin_lock_bh(&css_set_lock);

		css_set_move_task(tsk, cset, NULL, false);

		spin_unlock_bh(&css_set_lock);

		put_cset = true;

	} else {

		get_css_set(cset);

	}



	/* Reassign the task to the init_css_set. */

	RCU_INIT_POINTER(tsk->cgroups, &init_css_set);



	/* see cgroup_post_fork() for details */

	for_each_subsys_which(ss, i, &have_exit_callback) {

		struct cgroup_subsys_state *old_css = cset->subsys[i];

		struct cgroup_subsys_state *css = task_css(tsk, i);



		ss->exit(css, old_css, tsk);

	for_each_subsys_which(ss, i, &have_exit_callback)

		ss->exit(tsk);

}



	if (put_cset)

void cgroup_free(struct task_struct *task)

{

	struct css_set *cset = task_css_set(task);



	put_css_set(cset);

}

kernel/cgroup_pids.c

+2 −4
Original line number Diff line number Diff line
@@ -266,11 +266,9 @@ static void pids_fork(struct task_struct *task, void *priv) 
	css_put(old_css);

}



static void pids_exit(struct cgroup_subsys_state *css,

		      struct cgroup_subsys_state *old_css,

		      struct task_struct *task)

static void pids_exit(struct task_struct *task)

{

	struct pids_cgroup *pids = css_pids(old_css);

	struct pids_cgroup *pids = css_pids(task_css(task, pids_cgrp_id));



	pids_uncharge(pids, 1);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE