[media] omap3isp: ccdc: Simplify the configuration function (2e8f0172) · Commits · 戴 / test

Assign the format variable to the sink pad format earlier and use it instead of accessing the sink pad format directly from the ISP structure. Signed-off-by:

Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by:

Enrico Butera <ebutera@users.sourceforge.net> Acked-by:

Sakari Ailus <sakari.ailus@iki.fi> Signed-off-by:

Mauro Carvalho Chehab <m.chehab@samsung.com>

drivers/media/platform/omap3isp/ispccdc.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -1114,6 +1114,9 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc)
		pdata = &((struct isp_v4l2_subdevs_group *)sensor->host_priv)
		->bus.parallel;

		/* CCDC_PAD_SINK */
		format = &ccdc->formats[CCDC_PAD_SINK];

		/* Compute the lane shifter shift value and enable the bridge when the
		* input format is YUV.
		*/
		@@ -1124,8 +1127,7 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc)
		depth_in = fmt_info->width;
		}

		fmt_info = omap3isp_video_format_info
		(isp->isp_ccdc.formats[CCDC_PAD_SINK].code);
		fmt_info = omap3isp_video_format_info(format->code);
		depth_out = fmt_info->width;
		shift = depth_in - depth_out;

		@@ -1157,9 +1159,6 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc)
		else
		syn_mode &= ~ISPCCDC_SYN_MODE_SDR2RSZ;

		/* CCDC_PAD_SINK */
		format = &ccdc->formats[CCDC_PAD_SINK];

		/* Mosaic filter */
		switch (format->code) {
		case V4L2_MBUS_FMT_SRGGB10_1X10:

Admin message