Commit 2e7b162c authored Feb 26, 2019 by Li RongQing Committed by Pablo Neira Ayuso Mar 01, 2019

netfilter: nf_conntrack: ensure that CONNTRACK_LOCKS is power of 2



CONNTRACK_LOCKS is divisor when computer array index, if it is power of
2, compiler will optimize modulo operation as bitwise AND, or else
modulo will lower performance.

Suggested-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent a9f5e78c

net/netfilter/nf_conntrack_core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2480,6 +2480,7 @@ int nf_conntrack_init_net(struct net *net)
		int cpu;

		BUILD_BUG_ON(IP_CT_UNTRACKED == IP_CT_NUMBER);
		BUILD_BUG_ON_NOT_POWER_OF_2(CONNTRACK_LOCKS);
		atomic_set(&net->ct.count, 0);

		net->ct.pcpu_lists = alloc_percpu(struct ct_pcpu);

Admin message