Commit 2e65c7a6 authored Sep 26, 2018 by Tomi Valkeinen

drm/omap: fix use of freed memory



omap_connector_destroy() does:

kfree(omap_connector);
omapdss_device_put(omap_connector->output);
omapdss_device_put(omap_connector->display);

Fix this by moving the kfree after the omapdss_device_puts.

This bug was introduced in 949ea2ef

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

parent 08bafffe

drivers/gpu/drm/omapdrm/omap_connector.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -164,10 +164,11 @@ static void omap_connector_destroy(struct drm_connector *connector)

		drm_connector_unregister(connector);
		drm_connector_cleanup(connector);
		kfree(omap_connector);

		omapdss_device_put(omap_connector->output);
		omapdss_device_put(omap_connector->display);

		kfree(omap_connector);
		}

		#define MAX_EDID 512

Admin message