Commit 2e591bbc authored Dec 06, 2006 by Arjan van de Ven Committed by Linus Torvalds Dec 07, 2006

[PATCH] Make initramfs printk a warning on incorrect cpio type



It turns out that the "-c" option of cpio is highly unportable even between
distros let alone unix variants, and may actually make the wrong type of
cpio archive.  I just wasted quite some time on this, and the kernel can
detect this and warn about it (it's __init memory so it gets thrown away
and thus there is no runtime overhead)

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f6337e2a

init/initramfs.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -182,6 +182,10 @@ static int __init do_collect(void)

		static int __init do_header(void)
		{
		if (memcmp(collected, "070707", 6)==0) {
		error("incorrect cpio method used: use -H newc option");
		return 1;
		}
		if (memcmp(collected, "070701", 6)) {
		error("no cpio magic");
		return 1;

Admin message