Commit 2e4c3329 authored by David Miller's avatar David Miller Committed by James Bottomley
Browse files

[SCSI] sd, sym53c8xx: Remove warnings after vsprintf %pV introducation. 



GCC warns about empty printf format strings, and after
the addition of %pV these existing such cases in the
scsi driver layer were exposed enough for the compiler
to start seeing them.

Based almost entirely upon a patch by Joe Perches.

[jejb: fix up sym53c8xx msg]
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 6f131ce1

drivers/scsi/sym53c8xx_2/sym_hipd.c

+4 −6
Original line number Diff line number Diff line
@@ -72,10 +72,7 @@ static void sym_printl_hex(u_char *p, int n) 


static void sym_print_msg(struct sym_ccb *cp, char *label, u_char *msg)

{

	if (label)

	sym_print_addr(cp->cmd, "%s: ", label);

	else

		sym_print_addr(cp->cmd, "");



	spi_print_msg(msg);

	printf("\n");
@@ -4558,7 +4555,8 @@ static void sym_int_sir(struct sym_hcb *np) 
			switch (np->msgin [2]) {

			case M_X_MODIFY_DP:

				if (DEBUG_FLAGS & DEBUG_POINTER)

					sym_print_msg(cp, NULL, np->msgin);

					sym_print_msg(cp, "extended msg ",

						      np->msgin);

				tmp = (np->msgin[3]<<24) + (np->msgin[4]<<16) + 

				      (np->msgin[5]<<8)  + (np->msgin[6]);

				sym_modify_dp(np, tp, cp, tmp);
@@ -4585,7 +4583,7 @@ static void sym_int_sir(struct sym_hcb *np) 
		 */

		case M_IGN_RESIDUE:

			if (DEBUG_FLAGS & DEBUG_POINTER)

				sym_print_msg(cp, NULL, np->msgin);

				sym_print_msg(cp, "1 or 2 byte ", np->msgin);

			if (cp->host_flags & HF_SENSE)

				OUTL_DSP(np, SCRIPTA_BA(np, clrack));

			else

drivers/scsi/sd.c

+3 −3

File changed.

Contains only whitespace changes.

CRA Git | Maintained and supported by SUSTech CRA and CCSE