Commit 2e45e777 authored Apr 07, 2009 by Rusty Russell

Revert "module: remove the SHF_ALLOC flag on the __versions section."



This reverts commit 9cb610d8.

This was an impressively stupid patch.  Firstly, we reset the SHF_ALLOC
flag lower down in the same function, so the patch was useless.  Even
better, find_sec() ignores sections with SHF_ALLOC not set, so
it breaks CONFIG_MODVERSIONS=y with CONFIG_MODULE_FORCE_LOAD=n, which
refuses to load the module since it can't find the __versions section.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent d508afb4

kernel/module.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1952,9 +1952,6 @@ static noinline struct module load_module(void __user umod,
		if (strstarts(secstrings+sechdrs[i].sh_name, ".exit"))
		sechdrs[i].sh_flags &= ~(unsigned long)SHF_ALLOC;
		#endif
		/* Don't keep __versions around; it's just for loading. */
		if (strcmp(secstrings + sechdrs[i].sh_name, "__versions") == 0)
		sechdrs[i].sh_flags &= ~(unsigned long)SHF_ALLOC;
		}

		modindex = find_sec(hdr, sechdrs, secstrings,

Admin message