Commit 2e45676a authored Apr 16, 2020 by Madhuparna Bhowmik Committed by Vinod Koul Apr 23, 2020

dmaengine: pch_dma.c: Avoid data race between probe and irq handler



pd->dma.dev is read in irq handler pd_irq().
However, it is set to pdev->dev after request_irq().
Therefore, set pd->dma.dev to pdev->dev before request_irq() to
avoid data race between pch_dma_probe() and pd_irq().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Link: https://lore.kernel.org/r/20200416062335.29223-1-madhuparnabhowmik10@gmail.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent aee45dba

drivers/dma/pch_dma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -865,6 +865,7 @@ static int pch_dma_probe(struct pci_dev *pdev,
		}

		pci_set_master(pdev);
		pd->dma.dev = &pdev->dev;

		err = request_irq(pdev->irq, pd_irq, IRQF_SHARED, DRV_NAME, pd);
		if (err) {
		@@ -880,7 +881,6 @@ static int pch_dma_probe(struct pci_dev *pdev,
		goto err_free_irq;
		}

		pd->dma.dev = &pdev->dev;

		INIT_LIST_HEAD(&pd->dma.channels);

Admin message