Unverified Commit 2e4249f5 authored by Dan Murphy's avatar Dan Murphy Committed by Mark Brown
Browse files

ASoC: tlv320adcx140: Fix mic_bias and vref device tree verification 



Fix the range verification check for the mic_bias and vref device tree
entries.

Fixes 37bde5acf040 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")
Signed-off-by: default avatarDan Murphy <dmurphy@ti.com>
Link: https://lore.kernel.org/r/20200304193427.16886-1-dmurphy@ti.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent cc6eb9b5

sound/soc/codecs/tlv320adcx140.c

+4 −6
Original line number Diff line number Diff line
@@ -748,9 +748,8 @@ static int adcx140_codec_probe(struct snd_soc_component *component) 
	if (ret)

		bias_source = ADCX140_MIC_BIAS_VAL_VREF;



	if (bias_source != ADCX140_MIC_BIAS_VAL_VREF &&

	    bias_source != ADCX140_MIC_BIAS_VAL_VREF_1096 &&

	    bias_source != ADCX140_MIC_BIAS_VAL_AVDD) {

	if (bias_source < ADCX140_MIC_BIAS_VAL_VREF ||

	    bias_source > ADCX140_MIC_BIAS_VAL_AVDD) {

		dev_err(adcx140->dev, "Mic Bias source value is invalid\n");

		return -EINVAL;

	}
@@ -760,9 +759,8 @@ static int adcx140_codec_probe(struct snd_soc_component *component) 
	if (ret)

		vref_source = ADCX140_MIC_BIAS_VREF_275V;



	if (vref_source != ADCX140_MIC_BIAS_VREF_275V &&

	    vref_source != ADCX140_MIC_BIAS_VREF_25V &&

	    vref_source != ADCX140_MIC_BIAS_VREF_1375V) {

	if (vref_source < ADCX140_MIC_BIAS_VREF_275V ||

	    vref_source > ADCX140_MIC_BIAS_VREF_1375V) {

		dev_err(adcx140->dev, "Mic Bias source value is invalid\n");

		return -EINVAL;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE