Commit 2e311fba authored Sep 23, 2013 by Stephen M. Cameron Committed by James Bottomley Nov 30, 2013

[SCSI] hpsa: do not discard scsi status on aborted commands



We inadvertantly discarded the scsi status for aborted commands.
For some commands (e.g. reads from tape drives) these can't be retried,
and if we discarded the scsi status, the scsi mid layer couldn't notice
anything was wrong and the error was not reported.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 54b2b50c

drivers/scsi/hpsa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1289,7 +1289,7 @@ static void complete_scsi_command(struct CommandList *cp)
		"has check condition: aborted command: "
		"ASC: 0x%x, ASCQ: 0x%x\n",
		cp, asc, ascq);
		cmd->result = DID_SOFT_ERROR << 16;
		cmd->result \|= DID_SOFT_ERROR << 16;
		break;
		}
		/* Must be some other type of check condition */

Admin message