mtd: rawnand: ingenic: Fix the RB gpio active-high property on qi, lb60 (2e263011) · Commits · 戴 / test

The rb-gpios semantics was undocumented and qi,lb60 (along with the ingenic driver) got it wrong. The active state encodes the NAND ready state, which is high level. Since there's no signal inverter on this board, it should be active-high. Let's fix that here for older DTs so we can re-use the generic nand_gpio_waitrdy() helper, and be consistent with what other drivers do. Suggested-by:

Paul Cercueil <paul@crapouillou.net> Signed-off-by:

Boris Brezillon <boris.brezillon@collabora.com> Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519232454.374081-3-boris.brezillon@collabora.com

drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c

+13 −1

Original line number	Diff line number	Diff line
		@@ -184,7 +184,7 @@ static int ingenic_nand_dev_ready(struct nand_chip *chip)
		{
		struct ingenic_nand *nand = to_ingenic_nand(nand_to_mtd(chip));

		return !gpiod_get_value_cansleep(nand->busy_gpio);
		return gpiod_get_value_cansleep(nand->busy_gpio);
		}

		static void ingenic_nand_ecc_hwctl(struct nand_chip *chip, int mode)
		@@ -343,6 +343,18 @@ static int ingenic_nand_init_chip(struct platform_device *pdev,
		nand->chip.legacy.dev_ready = ingenic_nand_dev_ready;
		}

		/*
		* The rb-gpios semantics was undocumented and qi,lb60 (along with
		* the ingenic driver) got it wrong. The active state encodes the
		* NAND ready state, which is high level. Since there's no signal
		* inverter on this board, it should be active-high. Let's fix that
		* here for older DTs so we can re-use the generic nand_gpio_waitrdy()
		* helper, and be consistent with what other drivers do.
		*/
		if (of_machine_is_compatible("qi,lb60") &&
		gpiod_is_active_low(nand->busy_gpio))
		gpiod_toggle_active_low(nand->busy_gpio);

		nand->wp_gpio = devm_gpiod_get_optional(dev, "wp", GPIOD_OUT_LOW);

		if (IS_ERR(nand->wp_gpio)) {

Admin message