Commit 2e1139d6 authored Dec 04, 2020 by Zhang Changzhong Committed by Michael S. Tsirkin Dec 18, 2020

vhost scsi: fix error return code in vhost_scsi_set_endpoint()



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 25b98b64 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent e152d8af

drivers/vhost/scsi.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
		if (!vhost_vq_is_setup(vq))
		continue;

		if (vhost_scsi_setup_vq_cmds(vq, vq->num))
		ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
		if (ret)
		goto destroy_vq_cmds;
		}

Admin message