Commit 2df37a19 authored Aug 22, 2013 by Vyacheslav Dubeyko Committed by Linus Torvalds Aug 23, 2013

nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error



Remove double call of bio_put() in nilfs_end_bio_write() for the case of
BIO_EOPNOTSUPP error detection.  The issue was found by Dan Carpenter
and he suggests first version of the fix too.

Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 93dbc1b3

fs/nilfs2/segbuf.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err)

		if (err == -EOPNOTSUPP) {
		set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
		bio_put(bio);
		/* to be detected by submit_seg_bio() */
		/* to be detected by nilfs_segbuf_submit_bio() */
		}

		if (!uptodate)

Admin message