Commit 2dee43ec authored Jan 25, 2019 by Dan Carpenter Committed by Takashi Iwai Jan 25, 2019

ALSA: fireface: Off by one in latter_handle_midi_msg()



The > should be >= or otherwise we potentially read one element beyond
the end of the ff->tx_midi_substreams[] array.

Fixes: 73f5537f ("ALSA: fireface: support tx MIDI functionality of Fireface UCX")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 205d6bcf

sound/firewire/fireface/ff-protocol-latter.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -293,7 +293,7 @@ static void latter_handle_midi_msg(struct snd_ff *ff, unsigned int offset,
	struct snd_rawmidi_substream *substream;		struct snd_rawmidi_substream *substream;
	unsigned int len;		unsigned int len;

	if (index > ff->spec->midi_in_ports)		if (index >= ff->spec->midi_in_ports)
	return;		return;

	switch (data & 0x0000000f) {		switch (data & 0x0000000f) {

Admin message