Commit 2de841ef authored Apr 23, 2018 by Takashi Iwai

ALSA: usb-audio: Fix forgotten conversion of control query functions

The recent code refactoring made the argument for some helper
functions to be the explicit UAC_CS_* and UAC2_CS_* value instead of
0-based offset.  However, there was one place left forgotten, and it
caused a regression on some devices appearing as the inconsistent
mixer setup.

This patch corrects the forgotten conversion.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199449


Fixes: 21e9b3e9 ("ALSA: usb-audio: fix uac control query argument")
Tested-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 1ba7862f

sound/usb/mixer.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1776,7 +1776,8 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid,
		build_feature_ctl(state, _ftr, ch_bits, control,
		&iterm, unitid, ch_read_only);
		if (uac_v2v3_control_is_readable(master_bits, control))
		build_feature_ctl(state, _ftr, 0, i, &iterm, unitid,
		build_feature_ctl(state, _ftr, 0, control,
		&iterm, unitid,
		!uac_v2v3_control_is_writeable(master_bits,
		control));
		}

Admin message