Commit 2de7852f authored Feb 20, 2019 by Peng Fan Committed by Dennis Zhou Feb 23, 2019

percpu: use nr_groups as check condition



group_cnt array is defined with NR_CPUS entries, but normally
nr_groups will not reach up to NR_CPUS. So there is no issue
to the current code.

Checking other parts of pcpu_build_alloc_info, use nr_groups as
check condition, so make it consistent to use 'group < nr_groups'
as for loop check. In case we do have nr_groups equals with NR_CPUS,
we could also avoid memory access out of bounds.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Dennis Zhou <dennis@kernel.org>

parent a3b22b9f

mm/percpu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2384,7 +2384,7 @@ static struct pcpu_alloc_info * __init pcpu_build_alloc_info(
		ai->atom_size = atom_size;
		ai->alloc_size = alloc_size;

		for (group = 0, unit = 0; group_cnt[group]; group++) {
		for (group = 0, unit = 0; group < nr_groups; group++) {
		struct pcpu_group_info *gi = &ai->groups[group];

		/*

Admin message