Commit 2dc98346 authored by Federico Vaga's avatar Federico Vaga Committed by Wolfram Sang
Browse files

i2c: ocores: do not handle IRQ if IF is not set 



If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt

To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.

Signed-off-by: default avatarFederico Vaga <federico.vaga@cern.ch>
Acked-by: default avatarPeter Korsgaard <peter@korsgaard.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent e7663ef5

drivers/i2c/busses/i2c-ocores.c

+6 −3
Original line number Diff line number Diff line
@@ -143,10 +143,9 @@ static inline u8 oc_getreg(struct ocores_i2c *i2c, int reg) 
	return i2c->getreg(i2c, reg);

}



static void ocores_process(struct ocores_i2c *i2c)

static void ocores_process(struct ocores_i2c *i2c, u8 stat)

{

	struct i2c_msg *msg = i2c->msg;

	u8 stat = oc_getreg(i2c, OCI2C_STATUS);

	unsigned long flags;



	/*
@@ -223,8 +222,12 @@ out: 
static irqreturn_t ocores_isr(int irq, void *dev_id)

{

	struct ocores_i2c *i2c = dev_id;

	u8 stat = oc_getreg(i2c, OCI2C_STATUS);



	if (!(stat & OCI2C_STAT_IF))

		return IRQ_NONE;



	ocores_process(i2c);

	ocores_process(i2c, stat);



	return IRQ_HANDLED;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE