Unverified Commit 2dbf0855 authored Aug 12, 2020 by Michał Mirosław Committed by Mark Brown Aug 17, 2020

regulator: cleanup regulator_ena_gpio_free()

Since only regulator_ena_gpio_request() allocates rdev->ena_pin, and it
guarantees that same gpiod gets same pin structure, it is enough to
compare just the pointers. Also we know there can be only one matching
entry on the list. Rework the code take advantage of the facts.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/3ff002c7aa3bd774491af4291a9df23541fcf892.1597195321.git.mirq-linux@rere.qmqm.pl

Signed-off-by: Mark Brown <broonie@kernel.org>

parent d3c73156

drivers/regulator/core.c

+12 −12

Original line number	Diff line number	Diff line
		@@ -2287,19 +2287,19 @@ static void regulator_ena_gpio_free(struct regulator_dev *rdev)

		/* Free the GPIO only in case of no use */
		list_for_each_entry_safe(pin, n, &regulator_ena_gpio_list, list) {
		if (pin->gpiod == rdev->ena_pin->gpiod) {
		if (pin->request_count <= 1) {
		pin->request_count = 0;
		if (pin != rdev->ena_pin)
		continue;

		if (--pin->request_count)
		break;

		gpiod_put(pin->gpiod);
		list_del(&pin->list);
		kfree(pin);
		rdev->ena_pin = NULL;
		return;
		} else {
		pin->request_count--;
		}
		}
		break;
		}

		rdev->ena_pin = NULL;
		}

		/**