Commit 2da897e5 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller
Browse files

bpf: fix csum setting for bpf_set_tunnel_key 



The fix in 35e2d115 ("tunnels: Allow IPv6 UDP checksums to be correctly
controlled.") changed behavior for bpf_set_tunnel_key() when in use with
IPv6 and thus uncovered a bug that TUNNEL_CSUM needed to be set but wasn't.
As a result, the stack dropped ingress vxlan IPv6 packets, that have been
sent via eBPF through collect meta data mode due to checksum now being zero.

Since after LCO, we enable IPv4 checksum by default, so make that analogous
and only provide a flag BPF_F_ZERO_CSUM_TX for the user to turn it off in
IPv4 case.

Fixes: 35e2d115 ("tunnels: Allow IPv6 UDP checksums to be correctly controlled.")
Fixes: c6c33454 ("bpf: support ipv6 for bpf_skb_{set,get}_tunnel_key")
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a8c4a252

include/uapi/linux/bpf.h

+3 −0
Original line number Diff line number Diff line
@@ -292,6 +292,9 @@ enum bpf_func_id { 
/* BPF_FUNC_skb_set_tunnel_key and BPF_FUNC_skb_get_tunnel_key flags. */

#define BPF_F_TUNINFO_IPV6		(1ULL << 0)



/* BPF_FUNC_skb_set_tunnel_key flags. */

#define BPF_F_ZERO_CSUM_TX		(1ULL << 1)



/* user accessible mirror of in-kernel sk_buff.

 * new fields can only be added to the end of this structure

 */

net/core/filter.c

+4 −2
Original line number Diff line number Diff line
@@ -1752,7 +1752,7 @@ static u64 bpf_skb_set_tunnel_key(u64 r1, u64 r2, u64 size, u64 flags, u64 r5) 
	u8 compat[sizeof(struct bpf_tunnel_key)];

	struct ip_tunnel_info *info;



	if (unlikely(flags & ~(BPF_F_TUNINFO_IPV6)))

	if (unlikely(flags & ~(BPF_F_TUNINFO_IPV6 | BPF_F_ZERO_CSUM_TX)))

		return -EINVAL;

	if (unlikely(size != sizeof(struct bpf_tunnel_key))) {

		switch (size) {
@@ -1776,7 +1776,7 @@ static u64 bpf_skb_set_tunnel_key(u64 r1, u64 r2, u64 size, u64 flags, u64 r5) 
	info = &md->u.tun_info;

	info->mode = IP_TUNNEL_INFO_TX;



	info->key.tun_flags = TUNNEL_KEY;

	info->key.tun_flags = TUNNEL_KEY | TUNNEL_CSUM;

	info->key.tun_id = cpu_to_be64(from->tunnel_id);

	info->key.tos = from->tunnel_tos;

	info->key.ttl = from->tunnel_ttl;
@@ -1787,6 +1787,8 @@ static u64 bpf_skb_set_tunnel_key(u64 r1, u64 r2, u64 size, u64 flags, u64 r5) 
		       sizeof(from->remote_ipv6));

	} else {

		info->key.u.ipv4.dst = cpu_to_be32(from->remote_ipv4);

		if (flags & BPF_F_ZERO_CSUM_TX)

			info->key.tun_flags &= ~TUNNEL_CSUM;

	}



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE