Commit 2da57c8e authored Jan 15, 2012 by Dan Carpenter Committed by Greg Kroah-Hartman Feb 09, 2012

staging: precedence bug in crystalhd_stop_tx_dma_engine()

The intent here is to see if we have cleared the DMA_START_BIT flag. We
clear it a couple lines later. The current code has a precedence bug so
it is equivalent to "if (!dma_cntrl) { ...".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a2f9dc55

drivers/staging/crystalhd/crystalhd_hw.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -868,8 +868,7 @@ static enum BC_STATUS crystalhd_stop_tx_dma_engine(struct crystalhd_hw *hw)

		BCMLOG(BCMLOG_DBG, "Stopping TX DMA Engine..\n");

		/* FIXME: jarod: invert dma_ctrl and check bit? or are there missing parens? */
		if (!dma_cntrl & DMA_START_BIT) {
		if (!(dma_cntrl & DMA_START_BIT)) {
		BCMLOG(BCMLOG_DBG, "Already Stopped\n");
		return BC_STS_SUCCESS;
		}