Commit 2d9e9776 authored Nov 05, 2015 by Josef Bacik Committed by Chris Mason Nov 25, 2015

Btrfs: use btrfs_get_fs_root in resolve_indirect_ref

The backref code will look up the fs_root we're trying to resolve our indirect
refs for, unfortunately we use btrfs_read_fs_root_no_name, which returns -ENOENT
if the ref is 0. This isn't helpful for the qgroup stuff with snapshot delete
as it won't be able to search down the snapshot we are deleting, which will
cause us to miss roots. So use btrfs_get_fs_root and send false for check_ref
so we can always get the root we're looking for. Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Signed-off-by: Chris Mason <clm@fb.com>

parent 967ef513

fs/btrfs/backref.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -355,7 +355,7 @@ static int __resolve_indirect_ref(struct btrfs_fs_info *fs_info,

		index = srcu_read_lock(&fs_info->subvol_srcu);

		root = btrfs_read_fs_root_no_name(fs_info, &root_key);
		root = btrfs_get_fs_root(fs_info, &root_key, false);
		if (IS_ERR(root)) {
		srcu_read_unlock(&fs_info->subvol_srcu, index);
		ret = PTR_ERR(root);

Admin message