[media] dvb_usb_v2: fix pid_filter callback error logging (2d9e7ea6) · Commits · 戴 / test

Code block braces were missing which leds broken error logging and compiler warning. drivers/media/usb/dvb-usb-v2/dvb_usb_core.c: In function 'dvb_usb_ctrl_feed': drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:291:12: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] Reported-by:

Stephen Rothwell <sfr@canb.auug.org.au> Reported-by:

Milan Tuma <milan.olin@seznam.cz> Signed-off-by:

Antti Palosaari <crope@iki.fi> Signed-off-by:

Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/usb/dvb-usb-v2/dvb_usb_core.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -283,14 +283,13 @@ static inline int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed,

		/* activate the pid on the device pid filter */
		if (adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER &&
		adap->pid_filtering &&
		adap->props->pid_filter)
		adap->pid_filtering && adap->props->pid_filter) {
		ret = adap->props->pid_filter(adap, dvbdmxfeed->index,
		dvbdmxfeed->pid, (count == 1) ? 1 : 0);
		if (ret < 0)
		dev_err(&d->udev->dev, "%s: pid_filter() " \
		"failed=%d\n", KBUILD_MODNAME,
		ret);
		dev_err(&d->udev->dev, "%s: pid_filter() failed=%d\n",
		KBUILD_MODNAME, ret);
		}

		/* start feeding if it is first pid */
		if (adap->feed_count == 1 && count == 1) {

Admin message