Unverified Commit 2d9bbd02 authored Dec 07, 2017 by Tobias Jordan Committed by Mark Brown Dec 07, 2017

spi: sun6i: disable/unprepare clocks on remove



sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable
clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to
disable/unprepare them if we're not suspended.
Replacing pm_runtime_disable() by pm_runtime_force_suspend() will ensure
that sun6i_spi_runtime_suspend() is called if needed.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 3558fe90 (spi: sunxi: Add Allwinner A31 SPI controller driver)
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4fbd8d19

drivers/spi/spi-sun6i.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -541,7 +541,7 @@ err_free_master:

		static int sun6i_spi_remove(struct platform_device *pdev)
		{
		pm_runtime_disable(&pdev->dev);
		pm_runtime_force_suspend(&pdev->dev);

		return 0;
		}

Admin message