Commit 2d99cf16 authored Mar 09, 2010 by Stanislaw Gruszka Committed by David S. Miller Mar 15, 2010

bnx2x: use smp_mb() to keep ordering of read write operations



Since we want to keep ordering of write to fp->bd_tx_cons and
netif_tx_queue_stopped(txq), what is read of txq->state, we have to use
general memory barrier.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d4a2ac3e

drivers/net/bnx2x_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp)
		* start_xmit() will miss it and cause the queue to be stopped
		* forever.
		*/
		smp_wmb();
		smp_mb();

		/* TBD need a thresh? */
		if (unlikely(netif_tx_queue_stopped(txq))) {

Admin message