Commit 2d9900f2 authored by David Howells's avatar David Howells
Browse files

afs: Fix dirty-region encoding on ppc32 with 64K pages 



The dirty region bounds stored in page->private on an afs page are 15 bits
on a 32-bit box and can, at most, represent a range of up to 32K within a
32K page with a resolution of 1 byte.  This is a problem for powerpc32 with
64K pages enabled.

Further, transparent huge pages may get up to 2M, which will be a problem
for the afs filesystem on all 32-bit arches in the future.

Fix this by decreasing the resolution.  For the moment, a 64K page will
have a resolution determined from PAGE_SIZE.  In the future, the page will
need to be passed in to the helper functions so that the page size can be
assessed and the resolution determined dynamically.

Note that this might not be the ideal way to handle this, since it may
allow some leakage of undirtied zero bytes to the server's copy in the case
of a 3rd-party conflict.  Fixing that would require a separately allocated
record and is a more complicated fix.

Fixes: 4343d008 ("afs: Get rid of the afs_writeback record")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
parent f86726a6

fs/afs/internal.h

+20 −4
Original line number Diff line number Diff line
@@ -861,7 +861,8 @@ struct afs_vnode_cache_aux { 
/*

 * We use page->private to hold the amount of the page that we've written to,

 * splitting the field into two parts.  However, we need to represent a range

 * 0...PAGE_SIZE inclusive, so we can't support 64K pages on a 32-bit system.

 * 0...PAGE_SIZE, so we reduce the resolution if the size of the page

 * exceeds what we can encode.

 */

#ifdef CONFIG_64BIT

#define __AFS_PAGE_PRIV_MASK	0x7fffffffUL
@@ -873,19 +874,34 @@ struct afs_vnode_cache_aux { 
#define __AFS_PAGE_PRIV_MMAPPED	0x8000UL

#endif



static inline unsigned int afs_page_dirty_resolution(void)

{

	int shift = PAGE_SHIFT - (__AFS_PAGE_PRIV_SHIFT - 1);

	return (shift > 0) ? shift : 0;

}



static inline size_t afs_page_dirty_from(unsigned long priv)

{

	return priv & __AFS_PAGE_PRIV_MASK;

	unsigned long x = priv & __AFS_PAGE_PRIV_MASK;



	/* The lower bound is inclusive */

	return x << afs_page_dirty_resolution();

}



static inline size_t afs_page_dirty_to(unsigned long priv)

{

	return ((priv >> __AFS_PAGE_PRIV_SHIFT) & __AFS_PAGE_PRIV_MASK) + 1;

	unsigned long x = (priv >> __AFS_PAGE_PRIV_SHIFT) & __AFS_PAGE_PRIV_MASK;



	/* The upper bound is immediately beyond the region */

	return (x + 1) << afs_page_dirty_resolution();

}



static inline unsigned long afs_page_dirty(size_t from, size_t to)

{

	return ((unsigned long)(to - 1) << __AFS_PAGE_PRIV_SHIFT) | from;

	unsigned int res = afs_page_dirty_resolution();

	from >>= res;

	to = (to - 1) >> res;

	return (to << __AFS_PAGE_PRIV_SHIFT) | from;

}



static inline unsigned long afs_page_dirty_mmapped(unsigned long priv)

fs/afs/write.c

+0 −5
Original line number Diff line number Diff line
@@ -90,11 +90,6 @@ int afs_write_begin(struct file *file, struct address_space *mapping, 
	_enter("{%llx:%llu},{%lx},%u,%u",

	       vnode->fid.vid, vnode->fid.vnode, index, from, to);



	/* We want to store information about how much of a page is altered in

	 * page->private.

	 */

	BUILD_BUG_ON(PAGE_SIZE - 1 > __AFS_PAGE_PRIV_MASK && sizeof(page->private) < 8);



	page = grab_cache_page_write_begin(mapping, index, flags);

	if (!page)

		return -ENOMEM;

CRA Git | Maintained and supported by SUSTech CRA and CCSE