Commit 2d90027b authored Apr 05, 2020 by Michael Straube Committed by Greg Kroah-Hartman Apr 13, 2020

staging: rtl8188eu: remove unnecessary asignment



Remove unnecessary asignment in SwLedBlink1(). The code path with the
asignment 'pLed->BlinkTimes = 0' is only executed when
'pLed->BlinkTimes' is already zero and the value is not changed between
the test 'if (pLed->BlinkTimes == 0)' and the asignment.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200405112230.31975-1-straube.linux@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c5a906e3

drivers/staging/rtl8188eu/core/rtw_led.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -188,7 +188,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
		msecs_to_jiffies(LED_BLINK_NO_LINK_INTERVAL_ALPHA));
		RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
		}
		pLed->BlinkTimes = 0;
		pLed->bLedBlinkInProgress = false;
		} else {
		if (pLed->bLedOn)

Admin message