Commit 2d88a331 authored Feb 06, 2016 by Wei Yongjun Committed by Jacek Anaszewski Mar 14, 2016

leds: leds-gpio: Fix return value check in create_gpio_led()



In case of error, the function gpio_to_desc() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent c9eec908

drivers/leds/leds-gpio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -104,8 +104,8 @@ static int create_gpio_led(const struct gpio_led *template,
		return ret;

		led_dat->gpiod = gpio_to_desc(template->gpio);
		if (IS_ERR(led_dat->gpiod))
		return PTR_ERR(led_dat->gpiod);
		if (!led_dat->gpiod)
		return -EINVAL;
		}

		led_dat->cdev.name = template->name;

Admin message