Commit 2d803dc8 authored Mar 30, 2018 by Arvind Yadav Committed by MyungJoo Ham Jul 18, 2018

PM / devfreq: use put_device() instead of kfree()



Never directly free @dev after calling device_register() or
device_unregister(), even if device_register() returned an error.
Always use put_device() to give up the reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

parent 12ba2c65

drivers/devfreq/devfreq.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -625,7 +625,8 @@ struct devfreq devfreq_add_device(struct device dev,
		err = device_register(&devfreq->dev);
		if (err) {
		mutex_unlock(&devfreq->lock);
		goto err_dev;
		put_device(&devfreq->dev);
		goto err_out;
		}

		devfreq->trans_table =
		@@ -672,6 +673,7 @@ err_init:
		mutex_unlock(&devfreq_list_lock);

		device_unregister(&devfreq->dev);
		devfreq = NULL;
		err_dev:
		if (devfreq)
		kfree(devfreq);

Admin message