libata: have ata_scsi_rw_xlat() fail invalid passthrough requests (2d727150) · Commits · 戴 / test

For passthrough requests, libata-scsi takes what the user passes in as gospel. This can be problematic if the user fills in the CDB incorrectly. One example of that is in request sizes. For read/write commands, the CDB contains fields describing the transfer length of the request. These should match with the SG_IO header fields, but libata-scsi currently does no validation of that. Check that the number of blocks in the CDB for passthrough requests matches what was mapped into the request. If the CDB asks for more data then the validated SG_IO header fields, error it. Reported-by:

Krishna Ram Prakash R <krp@gtux.in> Reviewed-by:

Kees Cook <keescook@chromium.org> Signed-off-by:

Jens Axboe <axboe@kernel.dk>

drivers/ata/libata-scsi.c

+21 −0

Original line number	Diff line number	Diff line
		@@ -1786,6 +1786,21 @@ nothing_to_do:
		return 1;
		}

		static bool ata_check_nblocks(struct scsi_cmnd *scmd, u32 n_blocks)
		{
		struct request *rq = scmd->request;
		u32 req_blocks;

		if (!blk_rq_is_passthrough(rq))
		return true;

		req_blocks = blk_rq_bytes(rq) / scmd->device->sector_size;
		if (n_blocks > req_blocks)
		return false;

		return true;
		}

		/**
		* ata_scsi_rw_xlat - Translate SCSI r/w command into an ATA one
		* @qc: Storage for translated ATA taskfile
		@@ -1830,6 +1845,8 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc)
		scsi_10_lba_len(cdb, &block, &n_block);
		if (cdb[1] & (1 << 3))
		tf_flags \|= ATA_TFLAG_FUA;
		if (!ata_check_nblocks(scmd, n_block))
		goto invalid_fld;
		break;
		case READ_6:
		case WRITE_6:
		@@ -1844,6 +1861,8 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc)
		*/
		if (!n_block)
		n_block = 256;
		if (!ata_check_nblocks(scmd, n_block))
		goto invalid_fld;
		break;
		case READ_16:
		case WRITE_16:
		@@ -1854,6 +1873,8 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc)
		scsi_16_lba_len(cdb, &block, &n_block);
		if (cdb[1] & (1 << 3))
		tf_flags \|= ATA_TFLAG_FUA;
		if (!ata_check_nblocks(scmd, n_block))
		goto invalid_fld;
		break;
		default:
		DPRINTK("no-byte command\n");

Admin message