Commit 2d68259d authored Jan 16, 2009 by Magnus Damm Committed by Thomas Gleixner Jan 16, 2009

clockevents: let set_mode() setup delta information



Allow the set_mode() clockevent callback to decide and fill in delta
details such as shift, mult, max_delta_ns and min_delta_ns.

With this change the clockevent can be registered without delta details
which allows us to keep the parent clock disabled until the clockevent
gets setup using set_mode().

Letting set_mode() fill in or update delta details allows us to save
power by disabling the parent clock while the clockevent is unused.
This may however make the parent clock rate change, so next time the
clockevent gets enabled we need let set_mode() to update the detla
details accordingly. Doing it at registration time is not enough.

Furthermore, the delta details seem unused in the case of periodic-only
clockevent drivers, so this change also allows registration of such
drivers without the delta details filled in.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 7cb36b6c

kernel/time/clockevents.c

+11 −9

Original line number	Diff line number	Diff line
		@@ -68,6 +68,17 @@ void clockevents_set_mode(struct clock_event_device *dev,
		if (dev->mode != mode) {
		dev->set_mode(mode, dev);
		dev->mode = mode;

		/*
		* A nsec2cyc multiplicator of 0 is invalid and we'd crash
		* on it, so fix it up and emit a warning:
		*/
		if (mode == CLOCK_EVT_MODE_ONESHOT) {
		if (unlikely(!dev->mult)) {
		dev->mult = 1;
		WARN_ON(1);
		}
		}
		}
		}

		@@ -168,15 +179,6 @@ void clockevents_register_device(struct clock_event_device *dev)
		BUG_ON(dev->mode != CLOCK_EVT_MODE_UNUSED);
		BUG_ON(!dev->cpumask);

		/*
		* A nsec2cyc multiplicator of 0 is invalid and we'd crash
		* on it, so fix it up and emit a warning:
		*/
		if (unlikely(!dev->mult)) {
		dev->mult = 1;
		WARN_ON(1);
		}

		spin_lock(&clockevents_lock);

		list_add(&dev->list, &clockevent_devices);

Admin message