Commit 2d513ef6 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Greg Kroah-Hartman
Browse files

Staging: lustre: lnet: Use list_first_entry_or_null 



This patch replaces list_empty and list_entry with
list_first_entry_or_null.
Done using coccinelle:

@@
expression e1,e2;
statement S;
@@
- if(!list_empty(...)){
  e2=
- list_entry(e1.next,
+ list_first_entry_or_null(&e1,
  ...);
+ if(e2){
...
}

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 19cc827b

drivers/staging/lustre/lnet/selftest/conrpc.c

+3 −4
Original line number Diff line number Diff line
@@ -123,11 +123,10 @@ lstcon_rpc_prep(lstcon_node_t *nd, int service, unsigned feats, 


	spin_lock(&console_session.ses_rpc_lock);



	if (!list_empty(&console_session.ses_rpc_freelist)) {

		crpc = list_entry(console_session.ses_rpc_freelist.next,

	crpc = list_first_entry_or_null(&console_session.ses_rpc_freelist,

					lstcon_rpc_t, crp_link);

	if (crpc)

		list_del_init(&crpc->crp_link);

	}



	spin_unlock(&console_session.ses_rpc_lock);

drivers/staging/lustre/lnet/selftest/framework.c

+3 −4
Original line number Diff line number Diff line
@@ -919,11 +919,10 @@ sfw_create_test_rpc(sfw_test_unit_t *tsu, lnet_process_id_t peer, 
	spin_lock(&tsi->tsi_lock);



	LASSERT(sfw_test_active(tsi));



	if (!list_empty(&tsi->tsi_free_rpcs)) {

		/* pick request from buffer */

		rpc = list_entry(tsi->tsi_free_rpcs.next,

	rpc = list_first_entry_or_null(&tsi->tsi_free_rpcs,

				       srpc_client_rpc_t, crpc_list);

	if (rpc) {

		LASSERT(nblk == rpc->crpc_bulk.bk_niov);

		list_del_init(&rpc->crpc_list);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE