Commit 2d4d689f authored Mar 18, 2016 by Andy Shevchenko Committed by Vinod Koul Apr 04, 2016

dmaengine: hsu: allow more than 3 descriptors

Current code allows only up to 3 descriptors to be programmed to the hardware
since it is used wrong calculations. Change % to min_t() to allow as many
descriptors as user supplied. At once it could be programmed up to 4
descriptors due to hardware limitations.

The issue was found under stress test, so it might not bother ordinary users.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent f55532a0

drivers/dma/hsu/hsu.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -77,8 +77,8 @@ static void hsu_dma_chan_start(struct hsu_dma_chan *hsuc)
		hsu_chan_writel(hsuc, HSU_CH_MTSR, mtsr);

		/* Set descriptors */
		count = (desc->nents - desc->active) % HSU_DMA_CHAN_NR_DESC;
		for (i = 0; i < count; i++) {
		count = desc->nents - desc->active;
		for (i = 0; i < count && i < HSU_DMA_CHAN_NR_DESC; i++) {
		hsu_chan_writel(hsuc, HSU_CH_DxSAR(i), desc->sg[i].addr);
		hsu_chan_writel(hsuc, HSU_CH_DxTSR(i), desc->sg[i].len);

Admin message