sound: rawmidi: disable active-sensing-on-close by default (2d4b8420) · Commits · 戴 / test

Sending an Active Sensing message when closing a port can interfere with the following data if the port is reopened and a note-on is sent before the device's timeout has elapsed. Therefore, it is better to disable this setting by default. Signed-off-by:

Clemens Ladisch <clemens@ladisch.de> Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/core/rawmidi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static int open_substream(struct snd_rawmidi *rmidi,
		return err;
		substream->opened = 1;
		if (substream->use_count++ == 0)
		substream->active_sensing = 1;
		substream->active_sensing = 0;
		if (mode & SNDRV_RAWMIDI_LFLG_APPEND)
		substream->append = 1;
		rmidi->streams[substream->stream].substream_opened++;

sound/core/seq/seq_midi.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -237,6 +237,7 @@ static int midisynth_use(void private_data, struct snd_seq_port_subscribe info
		memset(&params, 0, sizeof(params));
		params.avail_min = 1;
		params.buffer_size = output_buffer_size;
		params.no_active_sensing = 1;
		if ((err = snd_rawmidi_output_params(msynth->output_rfile.output, &params)) < 0) {
		snd_rawmidi_kernel_release(&msynth->output_rfile);
		return err;

Admin message