Commit 2d47fd12 authored Jul 13, 2016 by Marcelo Ricardo Leitner Committed by David S. Miller Jul 13, 2016

sctp: only check for ECN if peer is using it



Currently only read-only checks are performed up to the point on where
we check if peer is ECN capable, checks which we can avoid otherwise.
The flag ecn_ce_done is only used to perform this check once per
incoming packet, and nothing more.

Thus this patch moves the peer check up.

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d9cef425

net/sctp/sm_statefuns.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -6118,12 +6118,11 @@ static int sctp_eat_data(const struct sctp_association *asoc,
		* chunk later.
		*/

		if (!chunk->ecn_ce_done) {
		if (asoc->peer.ecn_capable && !chunk->ecn_ce_done) {
		struct sctp_af *af = SCTP_INPUT_CB(chunk->skb)->af;
		chunk->ecn_ce_done = 1;

		if (af->is_ce(sctp_gso_headskb(chunk->skb)) &&
		asoc->peer.ecn_capable) {
		if (af->is_ce(sctp_gso_headskb(chunk->skb))) {
		/* Do real work as sideffect. */
		sctp_add_cmd_sf(commands, SCTP_CMD_ECN_CE,
		SCTP_U32(tsn));

Admin message