Commit 2d2bfeb8 authored Sep 03, 2020 by Ursula Braun Committed by David S. Miller Sep 03, 2020

net/smc: set rx_off for SMCR explicitly



SMC tries to make use of SMCD first. If a problem shows up,
it tries to switch to SMCR. If the SMCD initializing problem shows
up after the SMCD connection has already been initialized, field
rx_off keeps the wrong SMCD value for SMCR, which results in corrupted
data at the receiver.
This patch adds an explicit (re-)setting of field rx_off to zero if the
connection uses SMCR.

Fixes: be244f28 ("net/smc: add SMC-D support in data transfer")
Reviewed-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fffe83c8

net/smc/smc_core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1356,6 +1356,8 @@ create:
		if (ini->is_smcd) {
		conn->rx_off = sizeof(struct smcd_cdc_msg);
		smcd_cdc_rx_init(conn); /* init tasklet for this conn */
		} else {
		conn->rx_off = 0;
		}
		#ifndef KERNEL_HAS_ATOMIC64
		spin_lock_init(&conn->acurs_lock);

Admin message