Commit 2d1ee87d authored Dec 27, 2009 by Julia Lawall Committed by Philipp Reisner Jan 04, 2010

drivers/block/drbd: Correct NULL test

Test the just-allocated value for NULL rather than some other value.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,y;
statement S;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
-   y
+   x
       == NULL)
 S
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>

parent c1152949

drivers/block/drbd/drbd_receiver.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3945,7 +3945,7 @@ static int drbd_do_auth(struct drbd_conf *mdev)
		}

		right_response = kmalloc(resp_size, GFP_NOIO);
		if (response == NULL) {
		if (right_response == NULL) {
		dev_err(DEV, "kmalloc of right_response failed\n");
		rv = 0;
		goto fail;

Admin message